Skip to content

Conversation

@himanoa
Copy link

@himanoa himanoa commented Dec 16, 2024

Prerequisites

  • Before opening a pull request, please check the HTML standard (https://html.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description of the change

Change the type signature of requestAnimationFrame
to pass the timestamp to the callback function,
matching the Web API specification where
requestAnimationFrame provides a DOMHighResTimeStamp parameter.

See. https://html.spec.whatwg.org/#animation-frames


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Change the type signature of requestAnimationFrame
to pass the timestamp to the callback function,
matching the Web API specification where
requestAnimationFrame provides a DOMHighResTimeStamp parameter.
@himanoa himanoa force-pushed the add-timestamp-argument branch from 0dfdff3 to 6a80a97 Compare December 16, 2024 14:37
@himanoa himanoa marked this pull request as draft December 16, 2024 15:33
@himanoa himanoa closed this Dec 16, 2024
@himanoa himanoa deleted the add-timestamp-argument branch December 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant