-
Notifications
You must be signed in to change notification settings - Fork 3
Update to v0.14.0-rc3 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kl0tl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t we also upgrade the bower dependencies to master?
Hm... I guess it doesn't hurt. Who knows. It might be required for those who will still decide to use bower when they update their library? |
Yea, we should upgrade the bower dependencies to master for all of these |
|
Just waiting for CI now. |
|
I think the same reasoning for only including bower.json in the core libraries applies here: I don't think we gain much from having both bower and spago configurations in the repo. It just means there's two workflows we need to maintain rather than one. We shouldn't keep two sets of dependencies in the repo if we're not maintaining them both, so if we want to maintain both bower and spago configurations here then we should ensure both of them are tested by CI. However, you don't need to have a spago.dhall in a package's repo in order to consume that package with spago, so from my point of view I think it's preferable to only support bower for people working on the package. |
|
Let's have this discussion on purescript/purescript#3942 |
|
Sounds good. I'll wait for you to post there. |
Backlinking to purescript/purescript#3942