Revert "FFI.md typo (#388)" #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 878390c.
|
Here's the reversion PR, if you decide that you want to revert. |
hdgarrood
approved these changes
Jun 23, 2021
|
@hdgarrood Why don't we use "has kind - To give meaningful types to those functions, it might be useful to define a type `Frob` at kind `Type`.
+ To give meaningful types to those functions, it might be useful to define a type `Frob` that has kind `Type`. |
|
That works too |
|
@jamesdbrock Which rendering makes more sense to you. The original one to which this PR reverts or the rendering I provided above? |
I like yours. |
|
Then let's go with the "has kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 878390c.
This reverts #388