Upgrade package set, tidy up #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
Nov 30, 2025
| ]; | ||
|
|
||
| # Users authorized to deploy to the registry. | ||
| deployers = import ./nix/deployers.nix; |
Member
Author
There was a problem hiding this comment.
This was unused code — the deployers are already imported directly into the module.nix
thomashoneyman
commented
Nov 30, 2025
| mkAppOutput = drv: { | ||
| type = "app"; | ||
| program = "${drv}/bin/${drv.name}"; | ||
| meta.description = drv.meta.description or "PureScript Registry ${drv.name}"; |
Member
Author
There was a problem hiding this comment.
New build warnings on missing meta fields in apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just set up a new machine and noticed some minor warnings in the codebase so went ahead and fixed them up. This included upgrading the package set.