Skip to content

Conversation

@stkb
Copy link
Contributor

@stkb stkb commented Nov 11, 2019

Should fix #483

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@stkb
Copy link
Contributor Author

stkb commented Nov 11, 2019

@kohanyirobert, could you try on your machine, replacing the contents of the spago file (no extension) in your global node_modules/spago folder, with this new version? It should make Ctrl-C work correctly in spago repl.

There is unfortunately still a slight issue. If you use Ctrl-C in the repl, then after you quit it (either with :quit or Ctrl-D) you get 2x this annoying prompt:

Terminate batch job (Y/N)?

This isn't caused by this change, but appears now because we're now exiting the process properly. (It's caused by the npm shims: if you use purs repl ... with a npm purescript installation, you get that prompt when quitting the repl too; but when you use spago repl you get it twice because you also have a spago npm shim). That prompt is annoying and difficult to get rid of. Also, for some reason it only appears if you've used Ctrl-C while in the repl.

@f-f
Copy link
Member

f-f commented Nov 11, 2019

@stkb I'm about to cut a release so let's merge this anyways, and we can followup with other PRs if we find issues with this fix

@stkb
Copy link
Contributor Author

stkb commented Nov 11, 2019

@f-f ok!

@stkb stkb merged commit 5feef51 into purescript:master Nov 11, 2019
@stkb stkb deleted the shim-sigint branch November 12, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting Ctrl-C in "spago repl" messes up prompt (cmd.exe, powershell.exe)

2 participants