-
Notifications
You must be signed in to change notification settings - Fork 200
Use Github Actions as CI #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github Actions as CI #602
Conversation
|
@pkkid can you setup the secrets in the repo? |
|
Not sure how much more I can validate these runs on my own repo. Tests are running reliably and now uploading coverage reports to codecov.io: https://github.com/jjlawren/python-plexapi/actions/runs/395247820. |
|
Great work! Secrets etc has been checked, is this something you have done? |
|
TODO: Update badges in readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds caching of the plexinc/pms-docker image so that it does not need to be pulled repeatedly from DockerHub.
See Docker cache workflow run here:
https://github.com/JonnyWong16/python-plexapi/runs/1490367581
|
I think this is finally in a good place and is ready to merge. Lots of thanks to @JonnyWong16 for many clever suggestions and additional validation. Badge on the repo has been changed to codecov.io. Travis is still in place, but can be decommissioned once we're comfortable here. Once Travis is disabled, #443 should be updated and merged. |
|
Lets go for it |
Travis has recently introduced a new pricing model which has impacted the CI runs for free plans. I've observed CI runs for this repo queued for over an hour before executing.
This PR provides the necessary config to use Github Actions as our CI instead. An example run of this config on my fork is available here: https://github.com/jjlawren/python-plexapi/actions/runs/369388047.
A few outstanding items that need to be addressed:
PLEXAPI_AUTH_MYPLEX_USERNAMEandPLEXAPI_AUTH_MYPLEX_PASSWORD(@pkkid)