Skip to content

Conversation

@jjlawren
Copy link
Collaborator

@jjlawren jjlawren commented Nov 18, 2020

Travis has recently introduced a new pricing model which has impacted the CI runs for free plans. I've observed CI runs for this repo queued for over an hour before executing.

This PR provides the necessary config to use Github Actions as our CI instead. An example run of this config on my fork is available here: https://github.com/jjlawren/python-plexapi/actions/runs/369388047.

A few outstanding items that need to be addressed:

  • Set repo env secrets for PLEXAPI_AUTH_MYPLEX_USERNAME and PLEXAPI_AUTH_MYPLEX_PASSWORD (@pkkid)
  • Add teardown step to remove temporary CI PMS/client from myplex account
  • Add coveralls.io (or codecov.io) integration
  • Add an action to publish to PyPI (currently handled by Travis) (Github action to publish to PyPI #443)
  • Remove Travis configuration

@Hellowlol
Copy link
Collaborator

@pkkid can you setup the secrets in the repo?

@jjlawren
Copy link
Collaborator Author

jjlawren commented Dec 2, 2020

Not sure how much more I can validate these runs on my own repo. Tests are running reliably and now uploading coverage reports to codecov.io: https://github.com/jjlawren/python-plexapi/actions/runs/395247820.

@Hellowlol
Copy link
Collaborator

Hellowlol commented Dec 2, 2020

Great work! Secrets etc has been checked, is this something you have done?

@JonnyWong16
Copy link
Collaborator

TODO: Update badges in readme.

Copy link
Collaborator

@JonnyWong16 JonnyWong16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds caching of the plexinc/pms-docker image so that it does not need to be pulled repeatedly from DockerHub.

See Docker cache workflow run here:
https://github.com/JonnyWong16/python-plexapi/runs/1490367581

@jjlawren
Copy link
Collaborator Author

jjlawren commented Dec 3, 2020

I think this is finally in a good place and is ready to merge. Lots of thanks to @JonnyWong16 for many clever suggestions and additional validation.

Badge on the repo has been changed to codecov.io. Travis is still in place, but can be decommissioned once we're comfortable here. Once Travis is disabled, #443 should be updated and merged.

@Hellowlol Hellowlol merged commit 3b015da into pushingkarmaorg:master Dec 3, 2020
@Hellowlol
Copy link
Collaborator

Lets go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants