Skip to content

Conversation

@JonnyWong16
Copy link
Collaborator

Description

Fix Collections stuck as partial object after reloading.

  • Removed isFullObject() from Playable.
  • Check if either _details_key or key is equal to the _initpath.

From my testing, I don't think this breaks any existing functionality. Should there be tests added to check isFullObject() for all the other media types similar to movies (https://github.com/pkkid/python-plexapi/blob/master/tests/test_video.py#L66)?

Fixes #605

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Hellowlol Hellowlol merged commit b623b43 into pushingkarmaorg:master Nov 23, 2020
JonnyWong16 added a commit to JonnyWong16/python-plexapi that referenced this pull request Dec 4, 2020
…bject

Fix Collections stuck as partial object after reloading
@JonnyWong16 JonnyWong16 deleted the bugfix/full_object branch May 13, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collections stuck as PlexPartialObject after reloading

2 participants