Skip to content

Fix gdm.GDM.find_by_content_type() #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2021
Merged

Fix gdm.GDM.find_by_content_type() #668

merged 3 commits into from
Feb 16, 2021

Conversation

Montellese
Copy link
Contributor

While trying to integrate plexapi.gdm.GDM.find_by_content_type() into my service I noticed that it always throws an error because it tries to extract Content_Type instead of Content-Type from the received data. The last commit of this PR fixes that.

I added two additional commits:

  • the first commit removes the unused attribute last_scan
  • the second commit adds missing documentation for the entries attribute

jjlawren
jjlawren approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@jjlawren jjlawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@jjlawren jjlawren merged commit 61dc373 into pushingkarmaorg:master Feb 16, 2021
This was referenced Mar 12, 2021
Closed
Closed
Closed
@Montellese Montellese deleted the bugfix/gdm_find_by_content_type branch March 23, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjlawren jjlawren jjlawren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Montellese @jjlawren