Skip to content

Conversation

withshubh
Copy link
Contributor

Description

This PR fixes a few issues that were affecting the code quality.

Summary of changes

  • Remove unnecessary use of comprehension
  • Remove unnecessary comprehension
  • Use literal syntax instead of function calls to create data structure
  • Pass string format arguments as logging method parameters
  • Remove unused imports
  • Remove unnecessary generator
  • Refactor if expression

@withshubh
Copy link
Contributor Author

Hwy @pkkid 👋 Please review this PR! ✨

Copy link
Collaborator

@jjlawren jjlawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good changes. Might as well fix this spelling mistake while we're at it.

Co-authored-by: jjlawren <jjlawren@users.noreply.github.com>
@withshubh
Copy link
Contributor Author

@jjlawren fixed ✨

@jjlawren
Copy link
Collaborator

Looks like a recent merge led to a conflict. Can you resolve?

@withshubh
Copy link
Contributor Author

@jjlawren done!

@jjlawren jjlawren merged commit 12cf146 into pushingkarmaorg:master Feb 24, 2021
@withshubh
Copy link
Contributor Author

@jjlawren I would like to inform you that I ran DeepSource analyzer on my fork of this repository to detect these issues. Have a look at the issues caught in this repository by DeepSource here.

DeepSource is a code review automation tool that detects code quality issues and helps you to automatically fix some of them. You can use DeepSource to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code.

Can I submit a new PR with the configuration file which I used to configure the analysis?
You can merge the configuration file to continuously analyze the repo and fix code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants