-
Notifications
You must be signed in to change notification settings - Fork 200
fix: code quality issues #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hwy @pkkid 👋 Please review this PR! ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good changes. Might as well fix this spelling mistake while we're at it.
Co-authored-by: jjlawren <jjlawren@users.noreply.github.com>
@jjlawren fixed ✨ |
Looks like a recent merge led to a conflict. Can you resolve? |
@jjlawren done! |
@jjlawren I would like to inform you that I ran DeepSource analyzer on my fork of this repository to detect these issues. Have a look at the issues caught in this repository by DeepSource here. DeepSource is a code review automation tool that detects code quality issues and helps you to automatically fix some of them. You can use DeepSource to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code. Can I submit a new PR with the configuration file which I used to configure the analysis? |
Description
This PR fixes a few issues that were affecting the code quality.
Summary of changes
if
expression