Skip to content

Conversation

JonnyWong16
Copy link
Collaborator

Description

Fix LibrarySection.totalViewSize() for photo libraries.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable (we don't have tests for photo libraries)

@JonnyWong16 JonnyWong16 requested a review from jjlawren March 29, 2021 07:29
Copy link
Collaborator

@jjlawren jjlawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives the expected count for photos now, and other library types return the same results as before. Looks good!

@jjlawren jjlawren merged commit 2e7ae1f into pushingkarmaorg:master Apr 5, 2021
@JonnyWong16 JonnyWong16 deleted the feature/library_search branch May 13, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants