Skip to content

Remove manual sorts/fields added to PMS #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Remove manual sorts/fields added to PMS #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfefbaf
Remove manual random sort
JonnyWong16 Jun 14, 2021
a2bfc9e
Remove manual artist last played field
JonnyWong16 Jun 14, 2021
c111150
Remove manual random sort test
JonnyWong16 Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions plexapi/library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,6 @@ def _manualSorts(self):
('guid', 'asc', 'Guid'),
('id', 'asc', 'Rating Key'),
('index', 'asc', '%s Number' % self.type.capitalize()),
('random', 'asc', 'Random'),
('summary', 'asc', 'Summary'),
('tagline', 'asc', 'Tagline'),
('updatedAt', 'asc', 'Date Updated')
Expand Down Expand Up @@ -2081,10 +2080,6 @@ def _manualFields(self):
('rating', 'integer', 'Critic Rating'),
('viewOffset', 'integer', 'View Offset')
])
elif self.type == 'artist':
additionalFields.extend([
('lastViewedAt', 'date', 'Artist Last Played')
])
elif self.type == 'track':
additionalFields.extend([
('duration', 'integer', 'Duration'),
Expand Down
3 changes: 0 additions & 3 deletions tests/test_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,6 @@ def test_library_MovieSection_search_sort(movies):
guid_asc = [r.guid for r in results_guid]
assert guid_asc == sorted(guid_asc)

results_random = movies.search(sort="random")
assert len(results_random) == len(results)

results_summary = movies.search(sort="summary")
summary_asc = [r.summary for r in results_summary]
assert summary_asc == sorted(summary_asc)
Expand Down