Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@puzzle-js/client-lib",
"main": "dist/index.js",
"version": "1.6.0",
"version": "1.6.1",
"author": "<emre.kul@trendyol.com>",
"license": "MIT",
"repository": {
Expand Down
4 changes: 4 additions & 0 deletions src/assetHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ export class AssetHelper {
}

static loadAssetSeries(assets: IPageLibAsset[], callback?: Function) {
if (!assets.length && callback) {
callback();
}

for (let i = 0, p: any = Promise.resolve(); i < assets.length; i++) {
p = p.then(() => new Promise(resolve => {
const asset = assets[i];
Expand Down
14 changes: 14 additions & 0 deletions test/assetHelper.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,18 @@ describe('Module - Asset Helper', () => {
});
});

it('should call given callback if assets length is 0', async (done) => {
// arrange
const spy = sinon.spy();
const assets: IPageLibAsset[] = [];

// act
await AssetHelper.loadAssetSeries(assets, spy);

// assert
setTimeout(() => {
expect(spy.calledOnce).to.eq(true);
done();
});
});
});