zenith vs solar_zenith in psm3 variable maps

[williamhobbs]

Should 'zenith': 'solar_zenith_angle', in REQUEST_VARIABLE_MAP instead be 'solar_zenith': 'solar_zenith_angle', ? In VARIABLE_MAP it is solar_zenith.

pvlib-python/pvlib/iotools/psm3.py

Lines 45 to 61 in 2ca40aa

	REQUEST_VARIABLE_MAP = {
	'ghi': 'ghi',
	'dhi': 'dhi',
	'dni': 'dni',
	'ghi_clear': 'clearsky_ghi',
	'dhi_clear': 'clearsky_dhi',
	'dni_clear': 'clearsky_dni',
	'zenith': 'solar_zenith_angle',
	'temp_air': 'air_temperature',
	'temp_dew': 'dew_point',
	'relative_humidity': 'relative_humidity',
	'pressure': 'surface_pressure',
	'wind_speed': 'wind_speed',
	'wind_direction': 'wind_direction',
	'albedo': 'surface_albedo',
	'precipitable_water': 'total_precipitable_water',
	}

[cwhanse]

I think @williamhobbs is correct, line 52 should be 'solar_zenith': 'solar_zenith_angle'

[ayushjariyal]

@williamhobbs Is this issue still unresolved?

[williamhobbs]

Is this issue still unresolved?

@ayushjariyal Yes, it it still unresolved. I already have another PR open, and will probably not start on this until that one is resolved, so feel free to work on it yourself, if that's why you are asking.

[ayushjariyal]

@williamhobbs Can you please review the changes and let me know if any further improvements are needed?

[williamhobbs]

@williamhobbs Can you please review the changes and let me know if any further improvements are needed?

@ayushjariyal, looks good to me!