Skip to content

Change solar_zenith to apparent_zenith when angle is refraction corrected #2449

@RDaxini

Description

@RDaxini

Is your feature request related to a problem? Please describe.
The term solar_zenith is used for both refraction-corrected (apparent) zenith angles and non-refraction-corrected zenith angles. Example functions from irradiance.py: klucher, haydavies, reindl, king, perez, and perez_driesse. Also examples in infinite_sheds.py: _shaded_fraction, get_irradiance_poa, and get_irradiance.

Describe the solution you'd like
Replace solar_zenith with apparent_zenith for refraction-corrected solar zenith angles. Both terms already have nomenclature entries.

Additional context
Incorrect (example):

solar_zenith : numeric
Refraction-corrected solar zenith. [degree]

solar_zenith : numeric
Apparent (refraction-corrected) zenith angles in decimal
degrees. ``solar_zenith`` must be >=0 and <=180.

Correct (example):
apparent_zenith : numeric
Refraction corrected solar zenith angle in degrees.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions