Fallback to using vim.ui.select as default picker

[rbhanot4739]

I see there is an issue opened for the full snacks picker but in the meantime can there be a workaround to fallback to using vim.ui.select if telescope or fzf-lua isn't installed?

Is there a starting point i can look up to at least try and get this working locally for me for couple of most frequent features i use from this plugin?

[williambdean]

open a PR for this even if it is draft. The other pickers have a template which can have "not implemented" functionality.

I dont know much about vim.ui.select and have to understand the capabilities there. Each picker supported basically reimplements logic. They are basically independent so you could add without touching the others. Consolidation can come later

[MuntasirSZN]

vim.ui.select is a good fallback, but there will be no preview.

[williambdean]

We can try. However, I suspect it will look terrible with, say, issue picker which can come back with hundreds of results

[williambdean]

Definitely doable. For example,

local gh = require "octo.gh"

local issues = gh.issue.list {
  json = "id,title,number",
  limit = 10,
  opts = { mode = "sync" },
}

issues = vim.json.decode(issues)

vim.ui.select(issues, {
  format_item = function(item)
      return item.title
    end,
  },
  function(item)
    print(item.title)
  end
)

Results in

Select one of:
1: Using alternative to `plenary.job`
2: Breakout `octo.gh.graphql` into `queries` and `mutations`
3: Expose exit code in callback
4: Discussion pop up
5: In all pickers, preview title is ""
6: Construct pr checks window using JSON
7: Reload PR on action
8: Do not hide `outdated` comments in review mode
9: Consolidate gh pr merge logic
10: Fallback to using vim.ui.select as default picker
Type number and <Enter> or click with the mouse (q or empty cancels):

What are your thoughts on this? Would this be something that you would be interested in implementing?

[MuntasirSZN]

Definitely doable. For example,

local gh = require "octo.gh"

local issues = gh.issue.list {
  json = "id,title,number",
  limit = 10,
  opts = { mode = "sync" },
}

issues = vim.json.decode(issues)

vim.ui.select(issues, {
  format_item = function(item)
      return item.title
    end,
  },
  function(item)
    print(item.title)
  end
)

Results in

Select one of:
1: Using alternative to `plenary.job`
2: Breakout `octo.gh.graphql` into `queries` and `mutations`
3: Expose exit code in callback
4: Discussion pop up
5: In all pickers, preview title is ""
6: Construct pr checks window using JSON
7: Reload PR on action
8: Do not hide `outdated` comments in review mode
9: Consolidate gh pr merge logic
10: Fallback to using vim.ui.select as default picker
Type number and <Enter> or click with the mouse (q or empty cancels):

What are your thoughts on this? Would this be something that you would be interested in implementing?

LGTM.

[williambdean]

Feel free to open a PR even if it is a draft!

[williambdean]

I've implemented this for actions, issues, prs, and discussions. This acts as a fallback if selected picker doesn't have picker implementated. There are still wholes for pickers like snacks .

[williambdean]

I've implemented this for actions, issues, prs, and discussions. This acts as a fallback if selected picker doesn't have picker implementated. There are still wholes for pickers like snacks.

If you would like to use directly, then picker can be set to default in the setup config. (Maybe not the best name)

[MuntasirSZN]

What about picker name is vim or builtin or something else?

[williambdean]

What about picker name is vim or builtin or something else?

Good thinking. I lean toward builtin but open to either

[williambdean]

vim.ui.select is a good fallback, but there will be no preview.

I think they are working toward a preview. Ive seen some talk of that