Skip to content

fix dynamic import #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfiess merged 3 commits into from
Dec 4, 2019
Merged

fix dynamic import #2142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c887ac4
fix dynamic import
npoltorapavlo Nov 22, 2019
3077650
remove some strange code
npoltorapavlo Nov 22, 2019
b2c372f
Update ESMLoader.js
mfiess Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/pxScene2d/src/rcvrcore/ESMLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ var getModule = async function (specifier, referencingModule) {
}
else
{
specifier = "http://" + baseString.substring(0, baseString.lastIndexOf("/")+1) + specifier;
let result = await loadHttpFile(referencingModule.context.global.sparkscene, specifier);
mod = loadJavaScriptModule(result, specifier, referencingModule.context);
}
Expand Down Expand Up @@ -433,8 +432,8 @@ var linker = async function (specifier, referencingModule) {
}
}

var importModuleDynamically = async function (specifier, { url }) {
var mod = await getModule(specifier,{ url });
var importModuleDynamically = async function (specifier, referencingModule) {
var mod = await getModule(specifier,referencingModule);
mod.instantiate();
await mod.evaluate();
return mod;
Expand Down