Skip to content

Conversation

@henryiii
Copy link
Collaborator

@henryiii henryiii commented Mar 16, 2023

Description

This is a followup to #4397, since my review was never addressed there. We could pin this exactly for each release, then it would be okay to even enable testing by default. But we'd have to remember to keep bumping it.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii added the python dev Working on development versions of Python label Mar 16, 2023
@rwgk
Copy link
Collaborator

rwgk commented Mar 16, 2023

To fix the Upstream failure: We need to backport the tests/test_exceptions.py change under google/pybind11clif@af5c653.

Related:

I still need to work on tweaking the error_fetch_and_normalize implementation in pytypes.h for Python 3.12. Probably only in a couple weeks, when the 102675 fix arrives here.

rwgk added 3 commits March 30, 2023 00:00
…2.0alpha6)

```
free(): invalid pointer

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test_embed is a Catch v2.13.9 host application.
Run with -? for options

-------------------------------------------------------------------------------
Custom PyConfig
-------------------------------------------------------------------------------
/home/runner/work/pybind11/pybind11/tests/test_embed/test_interpreter.cpp:175
...............................................................................

/home/runner/work/pybind11/pybind11/tests/test_embed/test_interpreter.cpp:179: FAILED:
  {Unknown expression after the reported line}
due to a fatal error condition:
  SIGABRT - Abort (abnormal termination) signal

===============================================================================
test cases:    6 |    5 passed | 1 failed
assertions: 1518 | 1517 passed | 1 failed
```
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @henryiii I added two commits so that all tests pass (skip or comment out what's currently broken). This PR is good to merge from my viewpoint.

@henryiii henryiii merged commit 4ce0517 into pybind:master Mar 30, 2023
@henryiii henryiii deleted the henryiii/ci/py312 branch March 30, 2023 14:29
@henryiii
Copy link
Collaborator Author

Fantastic, thanks!

@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 30, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python dev Working on development versions of Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants