Skip to content

fix timeout when firmware size is 10x packet size #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2020
Merged

fix timeout when firmware size is 10x packet size #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32f2120
fix timeout when firmware size is 10x packet size
dlech Dec 18, 2020
223947a
Merge branch 'master' into dlech
dlech Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sagas/flash-firmware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function* flashFirmware(action: FlashFirmwareFlashAction): Generator {
throw Error('Missing hub type in MaxProgramFlashSize');
}

for (let offset = 0; offset < firmware.length; offset += maxDataSize) {
for (let offset = 0; ; ) {
const payload = firmware.slice(offset, offset + maxDataSize);
const programAction = (yield put(
programRequest(info[0].startAddress + offset, payload.buffer),
Expand All @@ -289,6 +289,13 @@ function* flashFirmware(action: FlashFirmwareFlashAction): Generator {

yield put(progress(offset, firmware.length));

// we don't want to request checksum if this is the last packet since
// the bootloader will send a response to the program request already.
offset += maxDataSize;
if (offset >= firmware.length) {
break;
}

if (connectResult.canWriteWithoutResponse) {
// Request checksum every 10 packets to prevent buffer overrun on
// the hub because of sending too much data at once. The actual
Expand Down