Skip to content

pbio/drv/sound/sound_ev3: Fix playing a frequency of 0 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

pbio/drv/sound/sound_ev3: Fix playing a frequency of 0 #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/pbio/drv/sound/sound_ev3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ void pbdrv_sound_stop() {
}

void pbdrv_beep_start(uint32_t frequency, uint16_t sample_attenuator) {
// A frequency of 0 is equivalent to turning the sound off
if (frequency == 0) {
pbdrv_sound_stop();
return;
}

// Clamp the frequency into the supported range
if (frequency < 64) {
frequency = 64;
Expand Down