EV3 USB fixes. #358
Merged
EV3 USB fixes. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan on calling the next release v4. The main purpose of changing this now is so that the WebUSB BOS descriptors will point to labs.pybricks.com instead of code.pybricks.com. Also fix missing include in usb_common_desc.c to make this actually take effect.
Use the correct register when calling USBReset(). Also replace some hard-coded values with macros in the related TI library.
Fix the USB being in a bad state after a firmware update. The firmware updater uses the USB to transfer the new firmware and then jumps to the new firmware without resetting the USB controller. Calling USBReset() was not enough to reset the USB controller. Even after this we would never get any interrupts, so requests from a host would time out. This is fixed by using the PSC to reset the USB controller instead of USBReset(). Also, before we reset things, we need to tell the host to disconnect from the firmware update USB device. When we reconfigure things the EV3 will appear as a completely different USB device. Fixes: pybricks/support#2295
Contributor
|
YES, Milestone 4.0 flashed the EV3 on the USB-2 of mammoet Linux Mint Flash no longer waits 30 seconds after EV3 restart. After a few reboots of the EV3, the EV3 is recognized: dmesg outputWindows I have no feeling that the REPL works more stable. Should |
Member
Author
Yup, that is the only thing being fixed here.
Still looking into this one. I can reproduce it on my Chromebook.
Perhaps @laurensvalk can help with that (
That isn't related to USB. See #357 (comment)
Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing pybricks/support#2295 plus bumping the firmware version so that the WebUSB descriptors point to
labs.pybricks.cominstead ofcode.pybricks.com.