[EV3] Remove SUART code which we will not use #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I don't know how much further we might want to specialize this interface, but the functions removed here will likely never be re-enabled. |
ArcaneNibble
force-pushed
the
suart_remove_not_used
branch
from
f81b10c to
6c81441
Compare
At this point, we are more-or-less committed to running our own firmware on PRU1. This means that we cannot use it for SUART instances. Remove support for running SUART across both PRUs in order to simplify the code and make it easier to understand.
We will never use these modes, since we need TX *and* RX. Remove them to make the code easier to understand.
Removes PRU1 register definitions and code which depends on them
ArcaneNibble
force-pushed
the
suart_remove_not_used
branch
from
6c81441 to
be92bf1
Compare
dlech
reviewed
Aug 5, 2025
Member
dlech
left a comment
dlech
left a comment
There was a problem hiding this comment.
Nice to remove all of this dead code.
This is not a complete automated reformat, but fix some particularly ugly line wrapping and spacing issues.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are already using PRU1, we cannot use dual-PRU mode for the SUART library. Remove support for this mode so that the code is easier to maintain and understand.