Skip to content

Conversation

@shaggysa
Copy link
Contributor

Let me know if there is anything I need to change, I'm not completely sure if I used the "correct" way to compare the firmware version.

@shaggysa
Copy link
Contributor Author

shaggysa commented Oct 24, 2025

I committed the wrong version before I saw your response, but that should be fixed now.

I also noticed that there is a method available to stop the hub program. It might be a good idea to add a feature to allow you to stop the program after you start it from the computer, but I'm not totally sure how that would work. I was thinking a keyboard interrupt, but I couldn't find a good way to intercept a KBI from the terminal because it automatically stops the entire asyncio runtime.

@dlech
Copy link
Member

dlech commented Oct 24, 2025

It might be a good idea to add a feature to allow you to stop the program after you start it from the compute

This is one aspect of a larger feature request. See #67.

@shaggysa
Copy link
Contributor Author

shaggysa commented Oct 24, 2025

This is one aspect of a larger feature request. See #67.

In that case, it would probably be a separate PR.

@dlech dlech merged commit 550b0ab into pybricks:master Oct 25, 2025
7 checks passed
@dlech
Copy link
Member

dlech commented Oct 25, 2025

Thanks again for another useful feature. We can always tweak the behavior if we need to after getting some feedback from more users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants