fix ble bug and compatible with the use cases from the documentation #18
Conversation
dlech
left a comment
dlech
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I have made some suggestions. Please have a look.
|
|
||
| print("Connecting to", device) | ||
| self.client = BleakClient(device) | ||
| self.client = BleakClient(device.address) |
There was a problem hiding this comment.
By passing the address instead of device object will cause Bleak to have to scan for the device again. This would make connections much slower.
| if device.name != name: | ||
| if device_or_address in [device.name, device.address]: | ||
| queue.put_nowait(device) | ||
| else: |
There was a problem hiding this comment.
else: return is not needed since there is nothing in the function after this.
| " address = await find_device('Pybricks Hub', timeout=5)\n", | ||
| " await hub.connect(address)\n", | ||
| " device = await find_device('Pybricks Hub', timeout=5)\n", | ||
| " await hub.connect(device.address)\n", |
There was a problem hiding this comment.
Shouldn't this be device and not device.address?
| async def find_device(name: str, timeout: float = 5) -> BLEDevice: | ||
| """Quickly find BLE device address by friendly device name. | ||
| async def find_device(device_or_address: str, timeout: float = 5) -> BLEDevice: | ||
| """Quickly find BLE device address by friendly device name or address. |
There was a problem hiding this comment.
We should also mention that "address" does not work on macOS. Instead, macOS assigns each device a UUID that has to be used instead of the Bluetooth address.
| Device was not found within the timeout. | ||
| """ | ||
| print("Searching for {0}".format(name)) | ||
| print("Searching for {0}".format(device_or_address)) |
There was a problem hiding this comment.
Since we need to make some other changes anyway, we could change this to:
| print("Searching for {0}".format(device_or_address)) | |
| print(f"Searching for {device_or_address}") |
dlech
force-pushed
the
master
branch
2 times, most recently
from
edc8734 to
069206f
Compare
|
This should be fixed in v1.0.0-alpha.8. |
2 participants
use cases from the documentation:
work on Mac!