Removed program running over USB #25
Conversation
|
Thanks for submitting this. I just realized that while it is true that USB is not supported on hubs with Pybricks, we do allow USB for running programs on hubs with the standard firmware. Sorry for the confusion - my bad.
So if we want to clarify this beyond just the README, we'd need to check the USB device name or something else to identify which firmware the hub is running. |
|
I see. I'll ditch my changes and update the |
|
Will we at least merge the doc changes? |
README.md
Outdated
| # | ||
| # usb connection examples: | ||
| # NOTE: running programs via usb connection works for standard firmwares only |
There was a problem hiding this comment.
It could be more clear to say "official LEGO firmware" instead of "standard firmware"
pybricksdev/cli/__init__.py
Outdated
| "conntype", | ||
| metavar="<connection type>", | ||
| help="connection type: %(choices)s", | ||
| help="connection type: %(choices)s; " |
There was a problem hiding this comment.
I think I would rather keep the help short and document the details at https://docs.pybricks.com/projects/pybricksdev (i.e. add a new section explaining the pybricksdev command line too and all of the commands). Otherwise we should also have to add a note here about ssh only working with EV3 running ev3dev and ble not working on EV3 to be complete.
There was a problem hiding this comment.
I think I'll leave this one with you. You know the best what the tool is compatible with rather than me.
Addresses #24.
|
Merged, thanks! |
3 participants
It is not supported and no hub uses USB anyway. Addresses #24.