Skip to content

Do not register an unpopulated VEnv #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arcivanov merged 1 commit into from
Sep 17, 2021
Merged

Do not register an unpopulated VEnv #798

arcivanov merged 1 commit into from
Sep 17, 2021

Conversation

@arcivanov
Copy link
Member

@arcivanov arcivanov commented Sep 17, 2021

fixes #797

@coveralls
Copy link

coveralls commented Sep 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1243830204

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.23%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/python/pybuilder/plugins/python/core_plugin.py 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
src/main/python/pybuilder/python_env.py 2 70.91%
src/main/python/pybuilder/reactor.py 4 91.12%
Totals Coverage Status
Change from base Build 1243702831: -0.2%
Covered Lines: 4978
Relevant Lines: 6049
💛 - Coveralls

@arcivanov arcivanov merged commit bd81189 into pybuilder:master Sep 17, 2021
@arcivanov arcivanov deleted the issue_797 branch September 17, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Registering unpopulated VEnv

2 participants

@arcivanov @coveralls