Skip to content

Ecdh kdf tests #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2015
Merged

Ecdh kdf tests #1907

merged 1 commit into from
Jun 2, 2015

Conversation

simo5
Copy link
Contributor

@simo5 simo5 commented May 6, 2015

Add separate pull request for testing the ECDH with KDF vectors as requested on #1884

@simo5 simo5 mentioned this pull request May 6, 2015
Merged
@simo5
Copy link
Contributor Author

simo5 commented May 6, 2015

This PR depends on #1884
We should probably hold on this until #1898 is also merged and add code to actually test the KDF derivation in the vectors.

@simo5
Modify ECDH Test vector loader for KDF vectors
83e563e 
Also add tests for the new vectors

Signed-off-by: Simo Sorce <simo@redhat.com>
@public
Copy link
Member

public commented May 10, 2015

I don't think we need to wait for a new KDF land to make use of these vectors.

@public
Copy link
Member

public commented May 10, 2015

LGTM

reaperhulk added a commit that referenced this pull request Jun 2, 2015
@reaperhulk
Merge pull request #1907 from simo5/ECDHKDFTests
43cd3d2 
Ecdh kdf tests
@reaperhulk reaperhulk merged commit 43cd3d2 into pyca:master Jun 2, 2015
@reaperhulk reaperhulk added this to the Tenth Release milestone Jun 2, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

testing vectors

Milestone

Tenth Release

Development

Successfully merging this pull request may close these issues.

3 participants

@simo5 @public @reaperhulk