Skip to content

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented Oct 16, 2015

@codecov-io
Copy link

Current coverage is 99.98%

Merging #2422 into master will not affect coverage as of 98e7d31

@@            master   #2422   diff @@
======================================
  Files          120     120       
  Stmts        12186   12186       
  Branches      1343    1343       
  Methods          0       0       
======================================
  Hit          12184   12184       
  Partial          2       2       
  Missed           0       0       

Review entire Coverage Diff as of 98e7d31

Powered by Codecov. Updated on successful CI builds.

@alex
Copy link
Member

alex commented Oct 16, 2015

cc: @dstufft

@reaperhulk
Copy link
Member

Should it be this flag or --no-use-wheel?

@Lukasa
Copy link
Member Author

Lukasa commented Oct 16, 2015

That's a good question: @dstufft would know.

@dstufft
Copy link
Member

dstufft commented Oct 16, 2015

Probably you want --no-binary cryptography, like:

$ CFLAGS="-I${CWD}/openssl/include" LDFLAGS="-L${CWD}/openssl/lib" pip wheel --no-binary cryptogrpahy cryptography

I think that will do what you want... although it only works in the latest pip, the --no-use-wheel version is deprecated but does the same thing (though it applies to everything and not just cryptography).

@dstufft
Copy link
Member

dstufft commented Oct 16, 2015

Specifically, the --no-use-wheel version is more compat with older versions, but is deprecated in favor of --no-binary.

@Lukasa
Copy link
Member Author

Lukasa commented Oct 17, 2015

@dstufft Is there any good reason not to use --no-use-wheel, then? I'm worried about providing instructions that only work with bleeding-edge pip.

@dstufft
Copy link
Member

dstufft commented Oct 17, 2015

It'll go away at some point, but that's it.

@Lukasa Lukasa force-pushed the static-build-docs branch from 0785a32 to 09d1b47 Compare October 18, 2015 13:35
@Lukasa
Copy link
Member Author

Lukasa commented Oct 18, 2015

Ok, I've switched to --no-use-wheel instead.

reaperhulk added a commit that referenced this pull request Oct 19, 2015
Add --no-cache-dir when building static wheels.
@reaperhulk reaperhulk merged commit ff59811 into pyca:master Oct 19, 2015
@coveralls
Copy link

coveralls commented Aug 7, 2017

Coverage Status

Changes Unknown when pulling 09d1b47 on Lukasa:static-build-docs into ** on pyca:master**.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants