Skip to content

Conversation

alex
Copy link
Member

@alex alex commented Aug 13, 2014

No description provided.

@alex
Copy link
Member Author

alex commented Aug 13, 2014

Needs pyca/cryptography#1303 to land first, and a cryptography release I think.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 77acc36 on alex:pkcs7-stuff into 1110bc9 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) when pulling 8fa1dd6 on alex:pkcs7-stuff into 1110bc9 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) when pulling 8fa1dd6 on alex:pkcs7-stuff into 1110bc9 on pyca:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a docstring.

@exarkun
Copy link
Member

exarkun commented Aug 14, 2014

Needs pyca/cryptography#1303 to land first, and a cryptography release I think.

In this case, please also bump the declared minimum supported version of cryptography in the setup.py metadata (once that version number is known).

Then, given a green build, please merge. Thanks.

@exarkun
Copy link
Member

exarkun commented Aug 14, 2014

You might also want to add an entry to the ChangeLog, I suppose.

@reaperhulk
Copy link
Member

👍

dreid added a commit that referenced this pull request Aug 26, 2014
Fixes #145 -- fixes loading pkcs7  data from ASN1
@dreid dreid merged commit 2739834 into pyca:master Aug 26, 2014
@alex alex deleted the pkcs7-stuff branch August 26, 2014 17:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants