Add re-add deprecated support for unicode in a variety of APIs #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

exarkun merged 21 commits into pyca:master from exarkun:issue-15

Apr 14, 2015

Member

exarkun commented Mar 29, 2015

Update of #189

abrahammartin and others added 11 commits

February 4, 2015 10:18


          Fix regressions in support for bytes / unicode

e82326c

Fix regressions in support for bytes / unicode in certain APIs pyca#15.
Added a check for _text_type, raise a DeprecationWarning and encode the
str to utf-8. This should preserve 0.13 API calls.
I used the 0.13 test suite with the 0.14 code and made the necessary
changes to make 0.13 and 0.14 tests pass.


          Emit proper warnings

2403ef5


          Different warning messages for different versions of Python

82efe3e


          Use six library to check python version

d2f0b07


          Reuse six imports

9778f41


          Tests for added backward compatibility in SSL.py

ef06348


          Tests for added backward compatibility in crypto.py

c5484ba


          Factor the warning code into a shared helper. Remove some of the unne…

6462b07

…cessary repetition from the tests.


          docstring

0894b17


          Remove the deprecation for this parameter that represents a path name.

607a380


          Use a spelling that is Python 2.6 compatible.

0c02199

coveralls commented Mar 29, 2015

Coverage decreased (-0.08%) to 94.57% when pulling 607a380 on exarkun:issue-15 into 2174e59 on pyca:master.

1 similar comment

coveralls commented Mar 29, 2015

Coverage decreased (-0.08%) to 94.57% when pulling 607a380 on exarkun:issue-15 into 2174e59 on pyca:master.

coveralls commented Mar 29, 2015

Coverage decreased (-0.08%) to 94.57% when pulling 0c02199 on exarkun:issue-15 into 2174e59 on pyca:master.

2 similar comments

coveralls commented Mar 29, 2015

Coverage decreased (-0.08%) to 94.57% when pulling 0c02199 on exarkun:issue-15 into 2174e59 on pyca:master.

coveralls commented Mar 29, 2015

Coverage decreased (-0.08%) to 94.57% when pulling 0c02199 on exarkun:issue-15 into 2174e59 on pyca:master.

exarkun added 3 commits

March 29, 2015 07:54


          I mean Python 2.6 compatible.

7578f35


          I mean Python 2.6.

13a0e65


          And Python 3.2 compatibility.

362c1f5

coveralls commented Mar 29, 2015

Coverage decreased (-0.28%) to 94.37% when pulling 13a0e65 on exarkun:issue-15 into 2174e59 on pyca:master.

1 similar comment

coveralls commented Mar 29, 2015

Coverage decreased (-0.28%) to 94.37% when pulling 13a0e65 on exarkun:issue-15 into 2174e59 on pyca:master.

coveralls commented Mar 29, 2015

Coverage decreased (-0.28%) to 94.37% when pulling 362c1f5 on exarkun:issue-15 into 2174e59 on pyca:master.


          One more.

8dc37a1

coveralls commented Mar 29, 2015

Coverage increased (+0.08%) to 94.72% when pulling 8dc37a1 on exarkun:issue-15 into 2174e59 on pyca:master.

2 similar comments

coveralls commented Mar 29, 2015

Coverage increased (+0.08%) to 94.72% when pulling 8dc37a1 on exarkun:issue-15 into 2174e59 on pyca:master.

coveralls commented Mar 29, 2015

Coverage increased (+0.08%) to 94.72% when pulling 8dc37a1 on exarkun:issue-15 into 2174e59 on pyca:master.

exarkun mentioned this pull request

Fix issue with string type check in python3 #182

Merged

Member

alex commented Apr 13, 2015

This is merge conflict'd because of a previous patch.

hynek reviewed

View reviewed changes

OpenSSL/test/test_ssl.py

Contributor

hynek Apr 14, 2015

these seem like an accident :)


          merge master, resolve simple conflicts

17eca48

hynek reviewed

View reviewed changes

OpenSSL/test/test_ssl.py Outdated

Contributor

hynek Apr 14, 2015

Depre*a*ctionWarning

exarkun added 3 commits

April 13, 2015 20:34


          Remove accidental space.

f188d23


          Remove unused import.

516c12c


          Fix wrapping and typo in warning name.

Contributor

hynek commented Apr 14, 2015

LGTM save the small things I pointed out.

exarkun added 2 commits

April 13, 2015 20:49


          Rename warn_text to something a little more descriptive.

39a8d59


          Merge master again!

da6399a

hynek reviewed

View reviewed changes

OpenSSL/test/test_crypto.py

Contributor

hynek Apr 14, 2015

warnings is a stdlib module therefore the import should be in the previous block

coveralls commented Apr 14, 2015

Coverage increased (+0.07%) to 95.16% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

4 similar comments

coveralls commented Apr 14, 2015

Coverage increased (+0.07%) to 95.16% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

coveralls commented Apr 14, 2015

Coverage increased (+0.07%) to 95.16% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

coveralls commented Apr 14, 2015

Coverage increased (+0.07%) to 95.16% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

coveralls commented Apr 14, 2015

Coverage increased (+0.07%) to 95.16% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

exarkun pushed a commit that referenced this pull request


          Merge pull request #201 from exarkun/issue-15

5c3b748

Re-add deprecated support for unicode in a variety of APIs.

exarkun merged commit 5c3b748 into pyca:master

exarkun deleted the issue-15 branch

April 14, 2015 01:41

coveralls commented Dec 3, 2016

Coverage increased (+0.7%) to 95.78% when pulling da6399a on exarkun:issue-15 into 2187374 on pyca:master.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet