Skip to content

Fix Travis CI #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2015
Merged

Fix Travis CI #260

merged 2 commits into from
May 14, 2015

Conversation

hynek
Copy link
Contributor

@hynek hynek commented May 14, 2015

sys.getfilesystemencoding() seems to be returning ascii now which breaks all builds.

@alex
Copy link
Member

alex commented May 14, 2015

tox doesn't pass environment variables (besides PATH) into the test process. You'd have to add LC_ALL to passenv in tox.ini

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.47%) to 92.65% when pulling 4c27243 on hynek:fix-fsencoding into e9ae673 on pyca:master.

@hynek
Copy link
Contributor Author

hynek commented May 14, 2015

thanks! next attempt.

@hynek hynek changed the title [WIP] Fix Travis CI [Fix Travis CI May 14, 2015
@hynek hynek changed the title [Fix Travis CI Fix Travis CI May 14, 2015
@hynek
Copy link
Contributor Author

hynek commented May 14, 2015

Tests are green again; please review/merge.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.45%) to 92.67% when pulling 2a617ce on hynek:fix-fsencoding into e9ae673 on pyca:master.

alex added a commit that referenced this pull request May 14, 2015
@alex
Merge pull request #260 from hynek/fix-fsencoding
dbbd0a9 
Fix Travis CI
@alex alex merged commit dbbd0a9 into pyca:master May 14, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hynek @alex @coveralls