Fix: problems of load_policy() and unittest for the current version code(59334bb) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When casbin.Enforcer is created, Adapter.load_policy() will be called, but sqlalchemy session is not commited in Adapter.load_policy(). The connection to database is held all the time till the first database operation, if the time interval between casbin.Enforcer created and first database operation occurs, exceeds database timeout setting, database operations like add_policy() and remove_policy() will raise timeout exception.
Filtered Policy Support
fix database connection timeout
feat: allow CasbinRule customization
…on when use multi processes(eg. Nginx reverse proxy)
|
@wangy8961 Could you please provide some test examples? |
|
Need advice from @techoner |
|
Closed as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] cannot see the insert/update/delete records from other transaction when use multi processes(eg. Nginx reverse proxy)
If you start two processes: transaction01 for process01, and transaction02 for process02
The default
isolationlevel of MySQL isRRWhen you insert/update/delete from transaction01, then transaction02 can't see the modify
We need to:
Before you call
e.enforce(sub, obj, act)，need to calle.load_policy()In
e.load_policy(), we need to commit the transaction before execute the SELECT SQL[Fix] the failing check of CI, unittest for the current version code(59334bb)