Add function to add user and group to roles #245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two separate functions added to add separately a user or a group to a given role.
|
|
| else: | ||
| logging.warning( | ||
| 'Failed to add user %s to role. Got code: %s' % (username, r.status_code)) | ||
| return r.status_code |
There was a problem hiding this comment.
This function returns bool or int as a result. I think that function result must be consistent - either all time returns bool or int.
|
There is a |
|
Ok that makes sense. I didn't see this method in the Role class. |
|
Closing as it would duplicate existing functionality. Even worse it would not re-use the same code. |
|
Where is the existing functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create automatically a JIRA project with all the proper permissions so I need to add users and groups to specific roles and they will change everytime. So I added two separate functions to add separately a user or a group to a given role.