Fix fetching all issues when maxResults is Falsy #275
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems that are currently affecting the ability to
fetch all results.
In older versions of this code when maxResults was falsy, it would
then change it to be 50, and then iterate over the code. This was
changed to a much more ideal method, however the old code blindly put
the value of maxResults into the dict of search params. It didn't matter
as it get reassigned pretty fast. The new code still put's it blindly
into the map, but then never reassigns it, and continues to do a search
with it to determin how many results there are. Which creates an invalid
search query. Solution: Remove it from being added to the map. It
actually never intentionally used in that map without having it
reassigned first.
There is this isLast code, which likely could be removed entirely.
It, according to the comment only works with the Jira agile module. If
jira doesn't know what isLast is, the code would return that is_last is
True. Obviously this is a bad failure case, as if we don't have the
agile module we can only ever return one page. Solution: Change the
default to False.