Skip to content

Fixes VirtualIP to_dict method to use vip id if available #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2013
Merged

Fixes VirtualIP to_dict method to use vip id if available #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyrax/cloudloadbalancers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,8 +1198,9 @@ def to_dict(self):
Convert this VirtualIP to a dict representation for passing
to the API.
"""
return {"type": self.type,
"ipVersion": self.ip_version}
if self.id:
return {"id": self.id}
return {"type": self.type, "ipVersion": self.ip_version}


@assure_parent
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_cloud_loadbalancers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,10 @@ def test_vip_repr(self):
vip_repr = "%s" % vip
self.assertTrue("address=1.2.3.4" in vip_repr)

def test_vip_to_dict(self):
vip = fakes.FakeVirtualIP(id="fake_id")
self.assertEqual(vip.to_dict(), {"id": "fake_id"})

def test_vip_to_dict(self):
vip = fakes.FakeVirtualIP()
expected = {"type": vip.type,
Expand Down