chore: explicitly call shutdown on drop of ShutdownHandler
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Thanks, I'll move forward with this and probably an accompanying split so that .configure() first returns a Logfire instance. Because this ShutdownHandler is currently cloneable and I think the on-drop type probably doesn't want to be to avoid surprises of the whole system shutting down when one of the cloned instances is dropped.
(I guess the internals could be reference-counted, but that doesn't feel totally satisfying to me either. I think it's nicer to have a real Logfire type.)
Agreed 😅. Please let me know what I / we (Shuttle) can do to help 😁. |
|
Think I have this done in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a simple
Dropimpl forShutdownHandlerto guaranteeShutdownHandler::shutdownis called, and "final" spans are sent.