Support serialization as any for Secret types and Url types
#10947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntic_serializer__
CodSpeed Performance ReportMerging #10947 will not alter performanceComparing Summary
|
Deploying pydantic-docs with
|
| Latest commit: |
a84e306
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9dc69f81.pydantic-docs.pages.dev |
| Branch Preview URL: | https://easier-ser.pydantic-docs.pages.dev |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
dmontagu
approved these changes
Nov 22, 2024
36 tasks
davidhewitt
approved these changes
Nov 25, 2024
Contributor
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
This seems fine for now 👍
It would be nice in the long run to either decide this is what we want users to do too, or to find a better way to support types with __get_pydantic_core_schema__.
1 task
sydney-runkle
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10946
Fixes #9491
This might not be the best approach, but relieves some pressure for now. Leans into the coupling between
pydanticandpydantic-core. I think it's better to lean into this than to pretend it doesn't exist.Working on docs test fixes