Skip to content

Fix Blosc import in test for zarr 3.1.13 #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fix Blosc import in test for zarr 3.1.13 #10756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53c7e68
Fix Blosc import in test for zarr 3.1.13
ianhi Sep 16, 2025
5c5b2a4
mypy
ianhi Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions xarray/tests/test_backends_datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@
assert tree["/SimpleGroup"].coords["Y"].dims == ("Y",)
assert tree["/SimpleGroup"].coords["X"].dims == ("X",)
with xr.open_dataset(url, engine=self.engine, group="/SimpleGroup") as expected:
assert set(tree["/SimpleGroup"].dims) == set(

Check failure on line 643 in xarray/tests/test_backends_datatree.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.13 flaky 

TestPyDAPDatatreeIO.test_inherited_coords

AssertionError: assert {'X', 'Y', 'Z', 'nv', 'time'} == {'X', 'Y', 'Z', 'nv'}
  
  Extra items in the left set:
  'time'
  
  Full diff:
    {
        'X',
        'Y',
        'Z',
        'nv',
  +     'time',
    }
list(expected.dims) + ["Z", "nv"]
)

Expand Down Expand Up @@ -678,9 +678,10 @@
comp = {"compressors": (codec,)} if has_zarr_v3 else {"compressor": codec}
elif zarr_format == 3:
# specifying codecs in zarr_format=3 requires importing from zarr 3 namespace
import numcodecs.zarr3
from zarr.registry import get_codec_class

comp = {"compressors": (numcodecs.zarr3.Blosc(cname="zstd", clevel=3),)}
Blosc = get_codec_class("numcodecs.blosc")
comp = {"compressors": (Blosc(cname="zstd", clevel=3),)} # type: ignore[call-arg]

enc = {"/set2": dict.fromkeys(original_dt["/set2"].dataset.data_vars, comp)}
original_dt.to_zarr(filepath, encoding=enc, zarr_format=zarr_format)
Expand Down
Loading