Fix mypy type checking errors #10883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type ignore comments for three mypy errors that appeared with updated type stubs: - CFTimeIndex.__add__ and __radd__ have simpler signatures than pandas Index - numpy dtype_out.type() call is valid but flagged by mypy stubs - Remove unused type ignore comment in test_plot.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
topic-cftime
topic-NamedArray
CI uses different pandas/numpy type stubs than local environment. Only keep the type: ignore[operator] for test_plot.py that CI needs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
ok, possibly #10878 just needed updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mypy type checking errors that appeared with updated type stubs:
type: ignore[override]toCFTimeIndex.__add__and__radd__methods which have simpler signatures than pandas Index supertype's complex overloaded signaturestype: ignore[call-arg]todtype_out.type(fill_value)call in dtypes.py - valid numpy code but incorrectly flagged by mypy stubstype: ignore[operator]comment in test_plot.py that is no longer neededTest plan
dmypy runpasses with no errorspre-commit run --all-filespasses🤖 Generated with Claude Code