Skip to content

Optimize padding for coarsening. #10921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

Optimize padding for coarsening. #10921

merged 3 commits into from
Nov 14, 2025

Conversation

@dcherian
Copy link
Contributor

@dcherian dcherian commented Nov 14, 2025

Disclaimer Used Claude to generate the benchmark

Pad once instead of repeatedly in serial for every dimension being coarsened.

| Before [6a7a11b5] <main>   | After [873f7ce6] |   Ratio | Benchmark (Parameter)                        |
|----------------------------|------------------|---------|----------------------------------------------|
| 856M                       | 727M             |    0.85 | coarsen.Coarsen.peakmem_coarsen_with_padding |
| 59.7±1ms                   | 49.9±0.4ms       |    0.84 | coarsen.Coarsen.time_coarsen_with_padding    |
| 729M                       | 597M             |    0.82 | coarsen.Coarsen.peakmem_coarsen_no_padding   |
| 55.2±0.4ms                 | 39.5±0.1ms       |    0.71 | coarsen.Coarsen.time_coarsen_no_padding      |
  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@dcherian @claude
Optimize padding for coarsening.
e153d21 
Pad once instead of repeatedly in serial for every dimension being
coarsened.
```
| Before [6a7a11b] <main>   | After [873f7ce6] |   Ratio | Benchmark (Parameter)                        |
|----------------------------|------------------|---------|----------------------------------------------|
| 856M                       | 727M             |    0.85 | coarsen.Coarsen.peakmem_coarsen_with_padding |
| 59.7±1ms                   | 49.9±0.4ms       |    0.84 | coarsen.Coarsen.time_coarsen_with_padding    |
| 729M                       | 597M             |    0.82 | coarsen.Coarsen.peakmem_coarsen_no_padding   |
| 55.2±0.4ms                 | 39.5±0.1ms       |    0.71 | coarsen.Coarsen.time_coarsen_no_padding      |
```

Co-authored-by: Claude <noreply@anthropic.com>
@dcherian dcherian added the run-benchmark Run the ASV benchmark workflow label Nov 14, 2025
@dcherian dcherian mentioned this pull request Nov 14, 2025
Open
19 tasks
@dcherian dcherian enabled auto-merge (squash) November 14, 2025 17:27
@dcherian dcherian merged commit 33ce95e into pydata:main Nov 14, 2025
36 checks passed
@dcherian dcherian deleted the optimize-coarsen-pad branch November 14, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomNicholas TomNicholas TomNicholas approved these changes

Assignees

No one assigned

Labels

run-benchmark Run the ASV benchmark workflow topic-performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcherian @TomNicholas