Skip to content

Conversation

@max-sixty
Copy link
Collaborator

  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Inspired by @Illviljan in #4750

@keewis
Copy link
Collaborator

keewis commented Jan 3, 2021

I would do that for isort, too, but otherwise looks good to me.

Be aware that #4730 replaces the current style check CI with a pre-commit CI, which automatically prints all changes.

@max-sixty
Copy link
Collaborator Author

Oh nice, I hadn't seen that. That's much better.

I'll merge this regardless but we can remove along with the rest of Azure when that merges — hopefully this will have a limited lifespan 😄

@max-sixty max-sixty merged commit aa3a738 into pydata:master Jan 3, 2021
@max-sixty max-sixty deleted the black branch January 3, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants