Skip to content

Conversation

@max-sixty
Copy link
Collaborator

  • Passes pre-commit run --all-files

As discussed in other issues — I find this way significantly easier to read, particularly when we're passing tuples of tuples as part of the construction. I did these manually but can write something to do it more broadly if people agree.

@shoyer
Copy link
Member

shoyer commented May 21, 2021

Personally I could go either way here. I find this roughly similarly readable, on average.

@max-sixty
Copy link
Collaborator Author

OK, I'll merge this but wait for more votes before expanding any further

@max-sixty max-sixty merged commit 96ce85c into pydata:master May 21, 2021
@max-sixty max-sixty deleted the dataset-construction-docs branch May 21, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants