feat: Support web app bundle @W-20091482 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second if block checking web_app paths can never execute because: - web_app bundles don't have meta.xml files - super.parseMetadataXml() returns undefined for web_app paths - The condition 'xml && isWebAppBaseType(path)' is always false
- Reduced path splitting from 3 times to 1 time - Removed unused pathParts variable - Improved code clarity with inline comments
- Added new snapshot test for DigitalExperienceBundle with web_app base type - Fixed merge conversion bug where files were placed at wrong directory level - Refactored duplicate code in digitalExperienceSourceAdapter - Added getWebAppBundleDir helper function to eliminate duplication
- Use posix.relative and posix.join to ensure consistent path separators - Fixes test failure on Windows CI where mixed path separators caused incorrect fullName generation - Child DigitalExperience components now get correct fullNames like 'web_app/zenith/index.html'
- Retrieve now reports individual files for web_app bundles - Fixes 'Nothing retrieved' warning when retrieving web_app bundles - Matches the deploy behavior for consistent file response reporting
Pulling changes from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for web_app DigitalExperienceBundle without meta.xml files
Summary
This PR adds support for web_app DigitalExperienceBundle metadata type that doesn't require meta.xml files.
Changes
Testing
@W-20091482