Activating virtualenvs fail with the fish shell

[fgimian]

Hey there, I've noticed that activating a virtualenv on the fish shell doesn't work. I tested this with a fresh Ubuntu 14.04 install and a new copy of pyenv.

fots@fotsies-ubtrusty-01~> pyenv global 2.7.6
fots@fotsies-ubtrusty-01~> pyenv virtualenv flaskage
Downloading/unpacking virtualenv
  Downloading virtualenv-1.11.6-py2.py3-none-any.whl (1.6MB): 1.6MB downloaded
Installing collected packages: virtualenv
Successfully installed virtualenv
Cleaning up...
New python executable in /home/fots/.pyenv/versions/flaskage/bin/python
Installing setuptools, pip...done.
fots@fotsies-ubtrusty-01~> pyenv activate flaskage
pyenv: version `/home/fots/.pyenv/versions/flaskage/bin/activate.fish' not installed
fots@fotsies-ubtrusty-01~>

Activating the virtualenv manually seems to work:

fots@fotsies-ubtrusty-01~> . /home/fots/.pyenv/versions/flaskage/bin/activate.fish
(flaskage)fots@fotsies-ubtrusty-01~> which python
/home/fots/.pyenv/versions/flaskage/bin/python
(flaskage)fots@fotsies-ubtrusty-01~> pyenv deactivate
fots@fotsies-ubtrusty-01~>

Your help on this would be greatly appreciated! 😄
Fotis

[fgimian]

I've been investigating this further and it seems to be a strange behaviour of the fish shell.

The biggest problem arises when running "eval" something which produces multiple lines.

e.g.

fots@fotsies-ubtrusty-01 ~> cat commands1
ls -l
fots@fotsies-ubtrusty-01 ~> eval (cat commands1)
total 8
-rw-rw-r-- 1 fots fots  6 May 31 11:34 commands1
-rw-rw-r-- 1 fots fots 14 May 31 11:34 commands2
lrwxrwxrwx 1 fots fots 18 May 31 10:26 pyenv -> /home/fots/.pyenv//
fots@fotsies-ubtrusty-01 ~> cat commands2
ls -l
echo hi
fots@fotsies-ubtrusty-01 ~> eval (cat commands2)
ls: cannot access echo: No such file or directory
ls: cannot access hi: No such file or directory

pyenv is evaluating the following command when activating a virtualenv:

pyenv sh-activate flaskage

And this contains multiple lines:

fots@fotsies-ubtrusty-01 ~> pyenv sh-activate flaskage
pyenv shell "flaskage"
. "/home/fots/.pyenv/versions/flaskage/bin/activate.fish"

So instead, it's running the command joined together like this:

fots@fotsies-ubtrusty-01 ~> pyenv shell "flaskage" . "/home/fots/.pyenv/versions/flaskage/bin/activate.fish"
pyenv: version `/home/fots/.pyenv/versions/flaskage/bin/activate.fish' not installed

I'm researching a workaround at the moment, but if you know a way to fix this, please let me know 😄

Cheers
Fotis

[fgimian]

Found a fix, I'll submit a pull request in a moment 😄

[fgimian]

Referencing the related issue for fish: fish-shell/fish-shell#159

[fgimian]

Since my pull request (which fixes this issue) is now merged, I'll close this one off 😄

Cheers
Fotis