Skip to content

Fix key.set_mods() type hint #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix key.set_mods() type hint #2457

merged 1 commit into from
Jan 22, 2021

Conversation

@w-v
Copy link
Contributor

@w-v w-v commented Jan 21, 2021

Fixes the signature type hint of the set_mods function to match the C code and the documentation

ankith26
ankith26 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!
Indeed the typehints were wrong before, and this PR fixes that.
Thanks 👍

@ankith26
Copy link
Contributor

Don’t mind the close/open. It’s just done to run the CI again :)

@illume illume changed the title Fix set_mods() type hint Fix key.set_mods() type hint Aug 21, 2021
@illume illume added key pygame.key types Type hint checking related tasks labels Aug 21, 2021
@illume illume added this to the 2.0.2 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ankith26 ankith26 ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

key pygame.key types Type hint checking related tasks

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@w-v @ankith26 @illume