Skip to content

Fix typo in display.set_gamma() that causes it to fail. #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2021
Merged

Fix typo in display.set_gamma() that causes it to fail. #2524

merged 1 commit into from
Mar 14, 2021

Conversation

@Starbuck5
Copy link
Contributor

Bug reported on Stackoverflow.

Relevant Docs: pygame.display.set_gamma

Unlike the SO user, on my end, display.set_gamma() always returned False. But this does fix it for me.

illume
illume approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me (g and b can't use the same offset). Thanks.

(I didn't test it by comparing it to pygame 1.9.x though)

@illume illume merged commit ed5336d into main Mar 14, 2021
@illume illume deleted the Starbuck5-display-set-gamma branch March 14, 2021 13:26
@illume illume added the display pygame.display label Aug 21, 2021
@illume illume added this to the 2.0.2 milestone Aug 21, 2021
@illume illume added bug Compatability (Pygame 2) Something that works in Pygame 1 but is broken in Pygame 2 labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illume illume illume approved these changes

Assignees

No one assigned

Labels

bug Compatability (Pygame 2) Something that works in Pygame 1 but is broken in Pygame 2 display pygame.display

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Starbuck5 @illume