Skip to content

Resolve incompatible char events #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

Resolve incompatible char events #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rendercanvas/glfw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,8 @@ def _on_char(self, window, char):
# Undocumented char event to make imgui work, see https://github.com/pygfx/wgpu-py/issues/530
ev = {
"event_type": "char",
"char_str": chr(char),
"data": chr(char),
"char_str": chr(char), # compat, remove few months from nov '25
"modifiers": tuple(self._key_modifiers),
}
self.submit_event(ev)
Expand Down
3 changes: 2 additions & 1 deletion rendercanvas/qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,8 @@ def _key_event(self, event_type, event):
def _char_input_event(self, char_str):
ev = {
"event_type": "char",
"char_str": char_str,
"data": char_str,
"char_str": char_str, # compat, remove few months from nov '25
"modifiers": None,
}
self.submit_event(ev)
Expand Down
3 changes: 2 additions & 1 deletion rendercanvas/wx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@ def _char_input_event(self, char_str: Optional[str]):

ev = {
"event_type": "char",
"char_str": char_str,
"data": char_str,
"char_str": char_str, # compat, remove few months from nov '25
"modifiers": None,
}
self.submit_event(ev)
Expand Down