Update Logtalk lexer for the latest language specification #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmoura
force-pushed
the
logtalk_lexer_update
branch
from
356d976 to
ea804c8
Compare
Anteru
reviewed
Nov 24, 2019
pygments/lexers/prolog.py
Outdated
| ], | ||
|
|
||
| 'quoted_atom': [ | ||
| (r"''", String), | ||
| (r"'", String, '#pop'), | ||
| (r"['][']", String), |
There was a problem hiding this comment.
Can you please shed some light on this? Why is a character class selector?
There was a problem hiding this comment.
No longer remember the motivation here. These changes are old (the original pull request was on BitBucket more than one year ago). But it works fine as I'm using this submitted version on a regular basis on a patched Pygments installation.
There was a problem hiding this comment.
Can you please give it a shot with "''" again? Other than that, should be ok to merge.
There was a problem hiding this comment.
Replace occurrences of ['] with ' and re-run the tests. No issues. Pushed the changes.
Anteru
requested changes
Nov 24, 2019
pmoura
force-pushed
the
logtalk_lexer_update
branch
from
ea804c8 to
c74543f
Compare
birkenfeld
reviewed
Nov 25, 2019
birkenfeld
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using the sample Logtalk source file available at:
https://github.com/LogtalkDotOrg/logtalk3/tree/master/coding/tests