Skip to content

Flux parallel debug #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Flux parallel debug #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09d361b
Add parallel flux test
jan-janssen Aug 3, 2023
66a0e16
Merge pull request #154 from pyiron/main
jan-janssen Aug 4, 2023
29feef4
Add parallel test to meta
jan-janssen Aug 4, 2023
88430fb
Disable parallel tests
jan-janssen Aug 4, 2023
3c820d9
comment out mpi function definitions
jan-janssen Aug 4, 2023
6732812
add mpi parallel tests
jan-janssen Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/test_flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class TestFlux(unittest.TestCase):
def setUp(self):
self.executor = FluxExecutor()

def test_flux_executor(self):
def test_flux_executor_serial(self):
with PyFluxExecutor(max_workers=2, executor=self.executor) as exe:
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
Expand All @@ -48,6 +48,12 @@ def test_flux_executor(self):
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_flux_executor_parallel(self):
with PyFluxExecutor(max_workers=1, cores_per_worker=2, executor=self.executor) as exe:
fs_1 = exe.submit(mpi_funct, 1)
self.assertEqual(fs_1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertTrue(fs_1.done())

def test_single_task(self):
with SingleTaskExecutor(cores=2, executor=self.executor) as p:
output = p.map(mpi_funct, [1, 2, 3])
Expand Down
15 changes: 14 additions & 1 deletion tests/test_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ def calc(i):
return i


def mpi_funct(i):
from mpi4py import MPI
size = MPI.COMM_WORLD.Get_size()
rank = MPI.COMM_WORLD.Get_rank()
return i, size, rank


class TestFutureCreation(unittest.TestCase):
def test_get_future_done(self):
f = _get_future_done()
Expand Down Expand Up @@ -57,11 +64,17 @@ def test_executor_broker(self):


class TestMetaExecutor(unittest.TestCase):
def test_meta_executor(self):
def test_meta_executor_serial(self):
with HPCExecutor(max_workers=2) as exe:
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_parallel(self):
with HPCExecutor(max_workers=1, cores_per_worker=2) as exe:
fs_1 = exe.submit(mpi_funct, 1)
self.assertEqual(fs_1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertTrue(fs_1.done())