add additional parameter to control if hostname of localhost is used #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-janssen
force-pushed
the
localhost
branch
from
ee35ff8 to
f6c7905
Compare
Member
Author
|
@liamhuber Just for you information. |
This was referenced Jan 31, 2024
Member
|
Thanks for the heads-up, @jan-janssen. The solution seems reasonable to me. I would suggest though to take the text of your explanatory comment above here and include it in the source code itself, so the intent is really clear. This could be in the docstring or even as a Edit: sorry, not at flag set, but adjacent to the if not host name clause |
Member
Author
|
This can be reverted once actions/runner-images#8649 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tests on
mac-os> 11 failed when we tried to establish the connection using the hostname fromfrom socket import gethostname. Now this pull request implements a switch to disable resolving the hostname. This is dangerous in distributed environments like HPC clusters, as we want to be able to access python processes on different hosts. So the default behaviour remains the same andfrom socket import gethostnameis used. Only for the tests this option is disabled and the hostname is set tolocalhostinstead. Naively I thought a computer would be able to resolve that its hostname refers tolocalhostbut it seems this behaviour changed inmac-os> 11.