Fix threads per core when submitting to queue #618

jan-janssen · 2025-03-28T08:12:43Z

Summary by CodeRabbit

Refactor
- Enhanced the system’s resource configuration logic to dynamically adjust processing capacity based on advanced thread settings. This update optimizes performance and ensures more efficient utilization of computing resources.

coderabbitai · 2025-03-28T08:12:50Z

Walkthrough

The changes update the handling of the "threads_per_core" key in the resource dictionary. A new conditional block checks for this key, and if it exists, it multiplies the "cores" value by the value of "threads_per_core" and then removes the key from the dictionary. Additionally, the previous removal of "threads_per_core" from unsupported_keys has been eliminated, streamlining the logic for resource adjustment.

Changes

File(s)	Change Summary
`executorlib/.../queue_spawner.py`	Added a conditional block to check for `"threads_per_core"` in `resource_dict`. If present, multiplies `"cores"` by its value and removes `"threads_per_core"`. Removed the line that previously deleted `"threads_per_core"` from `unsupported_keys`.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant QueueSpawner
    participant ResourceDict

    Caller->>QueueSpawner: Call spawn function
    QueueSpawner->>ResourceDict: Check if "threads_per_core" exists
    alt "threads_per_core" exists
        QueueSpawner->>ResourceDict: Multiply "cores" by threads_per_core value
        QueueSpawner->>ResourceDict: Remove "threads_per_core" from resource_dict
    else Not found
        QueueSpawner->>ResourceDict: Proceed with original logic
    end
    Note right of QueueSpawner: Removal from unsupported_keys is omitted

Poem

Hi, I'm your code rabbit on a joy-filled spree,
Hopping in logic where keys transform with glee.
"threads_per_core" now whispers a multiplication trick,
Then vanishes quietly, ever so slick.
Celebrate the change with a hop and a click! 🐰✨

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-03-28T08:15:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (a532b9d) to head (405c472).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files          28       28           
  Lines        1252     1255    +3     
=======================================
+ Hits         1207     1210    +3     
  Misses         45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a532b9d and 405c472.

📒 Files selected for processing (1)

executorlib/cache/queue_spawner.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: unittest_openmpi (macos-latest, 3.13)
GitHub Check: notebooks
GitHub Check: unittest_flux_mpich
GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
GitHub Check: unittest_openmpi (ubuntu-latest, 3.11)
GitHub Check: unittest_old
GitHub Check: unittest_openmpi (ubuntu-latest, 3.12)
GitHub Check: unittest_openmpi (ubuntu-latest, 3.13)
GitHub Check: unittest_mpich (ubuntu-latest, 3.12)
GitHub Check: unittest_mpich (ubuntu-latest, 3.11)
GitHub Check: unittest_mpich (ubuntu-latest, 3.13)
GitHub Check: unittest_win
GitHub Check: unittest_mpich (macos-latest, 3.13)
GitHub Check: unittest_flux_openmpi

coderabbitai · 2025-03-28T08:15:26Z

executorlib/cache/queue_spawner.py

+        if "threads_per_core" in resource_dict:
+            resource_dict["cores"] *= resource_dict["threads_per_core"]
+            del resource_dict["threads_per_core"]


🛠️ Refactor suggestion

Add validation to prevent potential errors.

The new code handles "threads_per_core" by multiplying it with "cores", but it's missing validation that could prevent runtime errors:

There's no check if "cores" exists in the dictionary before attempting to multiply

No validation that both values are numeric

No protection against "threads_per_core" being zero

if "threads_per_core" in resource_dict: - resource_dict["cores"] *= resource_dict["threads_per_core"] - del resource_dict["threads_per_core"] + threads = resource_dict.pop("threads_per_core") + if "cores" in resource_dict and threads: + resource_dict["cores"] *= threads + elif "cores" not in resource_dict and threads: + # Handle case where cores isn't defined but threads_per_core is + resource_dict["cores"] = threads

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

if "threads_per_core" in resource_dict:

resource_dict["cores"] *= resource_dict["threads_per_core"]

del resource_dict["threads_per_core"]

if "threads_per_core" in resource_dict:

threads = resource_dict.pop("threads_per_core")

if "cores" in resource_dict and threads:

resource_dict["cores"] *= threads

elif "cores" not in resource_dict and threads:

# Handle case where cores isn't defined but threads_per_core is

resource_dict["cores"] = threads

Fix threads per core when submitting to queue

405c472

coderabbitai bot reviewed Mar 28, 2025

View reviewed changes

jan-janssen merged commit 46f32e3 into main Mar 28, 2025
50 of 51 checks passed

jan-janssen deleted the threads_queue branch March 28, 2025 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix threads per core when submitting to queue #618

Fix threads per core when submitting to queue #618

Uh oh!

jan-janssen commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-        if "threads_per_core" in resource_dict:
-            resource_dict["cores"] *= resource_dict["threads_per_core"]
-            del resource_dict["threads_per_core"]
+        if "threads_per_core" in resource_dict:
+            threads = resource_dict.pop("threads_per_core")
+            if "cores" in resource_dict and threads:
+                resource_dict["cores"] *= threads
+            elif "cores" not in resource_dict and threads:
+                # Handle case where cores isn't defined but threads_per_core is
+                resource_dict["cores"] = threads

Fix threads per core when submitting to queue #618

Fix threads per core when submitting to queue #618

Uh oh!

Conversation

jan-janssen commented Mar 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jan-janssen commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Mar 28, 2025 •

edited

Loading